Integer #85

desmonddak · 2024-08-07T17:21:07Z

Description & Motivation

Adds a very general booth encoding multiplier with important subcomponents: generalized booth encoding (2,4,8,16 currently supported), Wallace tree column compression (delay-driven with heuristic fixed delays for column compressors), and reusing the parallel prefix adder components for the final adder.

The multiplier base supports different widths of operands (so rectangular products) as well as signed and unsigned operands. Testing is quite exhaustive across signed, radix, width, skew (width difference).

Also, we added a multiply-accumulate which is simply introducing the third operand as part of the column compression.

Related Issue(s)

None.

Testing

Randomized testing to cover the wide space of radix, widths, skew, and signage. Using a full multiply-accumulate tester to test both MAC and multiply by using a zero-term for the third operand to keep test code crisp. Especially tricky has been compact sign extension (keeping the number of rows the same) across different widths and skews for signed and unsigned and this was tested exhaustively.

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? If yes, how so?

Changed existing multipliers to use an abstract Multiply module base class.

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

Documentation updated with the multiplier classes. Also updated the confapp generator to allow for web-based visualization.

mkorbel1

This is great!

lib/src/arithmetic/booth.dart

doc/components/multiplier.md

lib/src/arithmetic/adder.dart

lib/src/arithmetic/booth.dart

test/arithmetic/booth_test.dart

test/arithmetic/compressor_test.dart

test/arithmetic/multiplier_test.dart

mkorbel1

whoops meant to request changes, not approve

desmonddak · 2024-08-11T17:28:55Z

I think I am done with updates.
I added a couple of proposed extensions to LogicValue because one I am now using (firstOne()) in printing during evaluation.
There are a couple of open issues to discuss:

A template for building input/output in a base Module and then deriving from that (the computeSum() issue). I think we should create a template in the documentation as this is a starting point for adding a component and it can be a bit confusing where to use this.<input> and late final, @protected, and get. A template and a few simple examples would go a long way.
The yosys bug and need for sv2v for the schematic (I added the multiplier to the web configurator for example)
My use of during-simulation evaluate code and how to structure that as an extension in test area only.
The extensions I added -- are these ok for now
A fair amount of restructured code based on your suggestions (folding in the sign extension into the constructor, getting rid of factory methods, etc.

desmonddak · 2024-08-11T18:01:52Z

I have one more set of changes I want to make: generalizing the full multiply tests.

README.md

lib/src/utils.dart

… use null

mkorbel1

new changes look good!

desmonddak · 2024-08-18T18:08:52Z

I'm working on documentation now...
I'm not sure if this PR has gone on too long and we should reopen to clear out too much history and small changes/bugfixes.

desmonddak · 2024-08-19T16:23:34Z

A few areas for focusing comments:

documentation that I added -- especially how much I should reference args and describe calling (I provide examples).
multiplier_lib.dart -- I had to pull this into rohd_hcl.dart anyway to get documentation produced, so we may need to remove this file and merge into rohd_hcl.dart for simplicity.
tests: I run regressions but can trim them down more. I like this idea of having singleton tests and then the regression loops as when a bug surfaces it is easier to reconstruct using a singleton.
an idea I had: it would be nice to construct small examples that get run in the test area but get included in the .md files -- that way we don't end up with documentation that is incorrect in terms of calling conventions.
I'm tempted to create another PR to remove all this clumsy history.

mkorbel1 · 2024-08-19T23:03:44Z

I'm not sure if this PR has gone on too long and we should reopen to clear out too much history and small changes/bugfixes.

@desmonddak doesn't matter, this will all get squashed into one nice pretty commit when it merges :)

doc/components/adder.md

lib/src/arithmetic/multiplier.dart

doc/components/multiplier_components.md

lib/src/arithmetic/sign_magnitude_adder.dart

lib/src/arithmetic/parallel_prefix_operations.dart

lib/src/arithmetic/partial_product_generator.dart

test/arithmetic/multiplier_encoder_test.dart

…ion fixes, new ones complement adder

…oc cleanup, split ones_complement_adder to its own file

lib/rohd_hcl.dart

lib/src/arithmetic/addend_compressor.dart

lib/src/arithmetic/parallel_prefix_operations.dart

lib/src/arithmetic/partial_product_generator.dart

doc/components/multiplier_components.md

lib/src/arithmetic/partial_product_generator.dart

test/arithmetic/adder_test.dart

… of comments, file headers.

…rator (not module)

mkorbel1

Looks good!

desmonddak added 6 commits August 6, 2024 21:00

integer arithmetic operations

03fcfcc

multiplier documentation and generator

e34ec22

spacing issue in doc

bb0326f

dart format

e8fd111

dart format

164a215

carry_save_multiplier cannot HANDLE different widths

31c2a8e

desmonddak requested a review from mkorbel1 August 7, 2024 18:27

desmonddak added 2 commits August 7, 2024 14:47

proper headers

0b4dafc

fixed header comments

6f4ae41

mkorbel1 approved these changes Aug 8, 2024

View reviewed changes

mkorbel1 requested changes Aug 8, 2024

View reviewed changes

desmonddak added 14 commits August 8, 2024 21:03

copyright updates

9768113

convert asserts to exceptions

ac60259

split/reorganize integer multiplication files

ae9055f

reorganized multiplier code

77a47a4

git failed to add all changes.

a7527c0

save issue or git issue

fe18879

test cleanup and more reorg of multiplier code

3e29ad1

cleanup compressors

2a29ceb

kill print statements

fd46336

fixed broken multiplier_lib

e8b96e8

integrated sign extension into PP generation

61521b5

fixed default arg warning

857b7b7

tuned up PP printout with a new LogicValue firstOne extension

e449c12

code cleanup, remove print, long lines

5a4cad7

much cleaner multiply test, sign args

32dde50

desmonddak requested a review from mkorbel1 August 12, 2024 15:05

mkorbel1 reviewed Aug 12, 2024

View reviewed changes

README.md Show resolved Hide resolved

lib/src/utils.dart Outdated Show resolved Hide resolved

lib/src/utils.dart Outdated Show resolved Hide resolved

desmonddak added 2 commits August 12, 2024 13:07

added test for majority() and fixed. updated LogicValue.firstOne() to…

d61c8b0

… use null

cleanup of API making more methods private, fixing SignMag adder API

a26a709

mkorbel1 reviewed Aug 13, 2024

View reviewed changes

desmonddak added 2 commits August 16, 2024 16:11

missed some final fixes

7da5003

fixed sign-mag to be correct width, fixed tests to be uniquely named

cde1c36

desmonddak added 2 commits August 18, 2024 18:36

reorg and add major multiplier internals documentation

bdd5f9a

remove links for now to pass lint

22da93f

desmonddak requested a review from mkorbel1 August 19, 2024 16:19

mkorbel1 reviewed Aug 31, 2024

View reviewed changes

mkorbel1 mentioned this pull request Aug 31, 2024

Integer divider #87

Merged

desmonddak added 3 commits August 31, 2024 18:08

major restructuring of partial product compressor classes, documentat…

a4d73b6

…ion fixes, new ones complement adder

simplify doc for multiplier

029c480

cleaned up interfaces using optional named args adderGen and ppGen, d…

79118f0

…oc cleanup, split ones_complement_adder to its own file

mkorbel1 reviewed Sep 4, 2024

View reviewed changes

desmonddak added 2 commits September 4, 2024 15:04

Hid ColumnCompression code, exposed AddendCompressor. General cleanup…

b88fda8

… of comments, file headers.

back out AddendCompressor and leave as a ColumnCompressor object gene…

4180ad9

…rator (not module)

mkorbel1 approved these changes Sep 5, 2024

View reviewed changes

desmonddak added 4 commits September 4, 2024 18:53

format issue

448b4e9

commit to force git to run the job

741e78e

remove unused import

b32b725

another unused import

9f7d84d

mkorbel1 approved these changes Sep 5, 2024

View reviewed changes

desmonddak merged commit 063c66e into intel:main Sep 5, 2024
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Integer #85

Integer #85

desmonddak commented Aug 7, 2024

mkorbel1 left a comment

mkorbel1 left a comment

desmonddak commented Aug 11, 2024 •

edited

Loading

desmonddak commented Aug 11, 2024

mkorbel1 left a comment

desmonddak commented Aug 18, 2024

desmonddak commented Aug 19, 2024

mkorbel1 commented Aug 19, 2024

mkorbel1 left a comment

Integer #85

Integer #85

Conversation

desmonddak commented Aug 7, 2024

Description & Motivation

Related Issue(s)

Testing

Backwards-compatibility

Documentation

mkorbel1 left a comment

Choose a reason for hiding this comment

mkorbel1 left a comment

Choose a reason for hiding this comment

desmonddak commented Aug 11, 2024 • edited Loading

desmonddak commented Aug 11, 2024

mkorbel1 left a comment

Choose a reason for hiding this comment

desmonddak commented Aug 18, 2024

desmonddak commented Aug 19, 2024

mkorbel1 commented Aug 19, 2024

mkorbel1 left a comment

Choose a reason for hiding this comment

desmonddak commented Aug 11, 2024 •

edited

Loading